Repository navigation
docs(orchestrator): enforce strict no-pause in lazy autopilot; fix workflow-creation loop bug - #274
Merged
Merged
Conversation
… workflow-creation loop Three related documentation fixes to the orchestrator prompt and its reference graph: 1. Stricter no-pause enforcement: add a dedicated section to the orchestrator agent prompt making explicit that lazy autopilot must never pause between tasks, waves, or intra-phase checkpoints except for the two enumerated hard stops (credentials/secrets; destructive operations). Reinforce that the runtime nudge is a safety net, not a permitted rhythm. Mirror this in phase-gates.md (lazy autopilot subsection) and task-decomposition.md (post-wave review gate gets an autopilot-skip subsection). 2. Fix a real workflow-creation loop bug observed in production: the orchestrator repeatedly regenerated a workflowId and re-issued create-workflow + set-active-workflow calls that had already succeeded, looping ~7 times with zero forward progress. Root cause was stale docs teaching the two-call pattern and never telling the orchestrator to trust a successful result. Replace the two-call sequence with the single-call activate:true form across goop-discuss.md and core-protocol.md, add a Trust Successful Tool Results subsection to core-protocol.md, and add an explicit anti-pattern bullet. 3. Fix guard-count drift: goop-execute.md said nine suppression guards while the actual implementation has eleven. Replace the hardcoded count and inline list with a pointer to the authoritative table in phase-gates.md so the doc cannot drift out of sync again. No source code changed; documentation and prompt files only.
… label The guard set has grown past nine (see phase-gates.md §Suppression Guards), so the label was misleading. Don't hardcode a new number; phase-gates.md is the source of truth for the guard count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Documentation/prompt-consistency fixes to the orchestrator's own prompt and its reference graph. No application logic changed except one stale test label.
Why
Stricter no-pause enforcement. The orchestrator's prompt didn't explicitly say "never pause between tasks/phases" as a standalone rule — that guidance was scattered and deviation-rule-specific. Added a dedicated
## Never Pause Between Tasks or Waves (Lazy Autopilot)section toagents/goop-orchestrator.mdnaming the only two valid hard stops (credentials/secrets; destructive/irreversible operations) and explicitly listing what does not qualify as a stopping point (deviations, phase transitions, checkpoints, PR creation, per-phase plan review). Mirrored inreferences/phase-gates.mdandreferences/task-decomposition.md.Fixes a real observed bug. In a live session, the orchestrator repeatedly regenerated a workflowId and re-issued
create-workflow+set-active-workflowcalls that had already succeeded — looping ~7 times with zero forward progress before a human caught it. Root cause:references/core-protocol.md's worked example still describedgoop_state'sactivate: trueflag as not-yet-landed ("once it lands...") even though it already exists and is already used correctly intool-reference.md; andcommands/goop-discuss.mdstill taught the stale two-call sequence — the exact pattern executed in the loop. No document anywhere said "a successful call is durable, don't retry it." Replaced the two-call pattern with the single-callactivate: trueform and added a new### Trust Successful Tool Resultsrule tocore-protocol.mdnaming the failure mode explicitly.Fixes drift found during the audit.
commands/goop-execute.mdclaimed the lazy-autopilot nudge has nine suppression guards; the real count (inphase-gates.mdand the implementation) is eleven (two were added later). Replaced the hardcoded count/list with a pointer tophase-gates.mdas the single source of truth. Also corrected a matching stale "nine guards" label inguards.test.ts.Files changed
agents/goop-orchestrator.md— new no-pause sectionreferences/phase-gates.md— mirrored no-pause language in the lazy autopilot subsectionreferences/task-decomposition.md— plan review gate autopilot-skip subsectioncommands/goop-discuss.md— single-callactivate: trueform + anti-pattern bulletreferences/core-protocol.md— updated worked example + new Trust Successful Tool Results subsectioncommands/goop-execute.md— guard count/list now points tophase-gates.mdsrc/hooks/lazy-autopilot-nudge/guards.test.ts— stale "nine guards" test label corrected (label-only, no behavior change)Verification
git log/git status/git show(not trusted on subagent response text alone).guards.test.ts— 28 pass / 0 fail, no behavior change (label-only edit).